Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2925#discussion_r95132586
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -88,6 +96,7 @@ protected ShardConsumer(KinesisDataFetcher<T> fetcherRef,
Integer
subscribedShardStateIndex,
KinesisStreamShard
subscribedShard,
SequenceNumber
lastSequenceNum,
+
AtomicReference<Throwable> error,
--- End diff --
I don't think you need to add this constructor argument here, because it
isn't used in the tests, correct?
This protected constructor exists for testing purposes. For example, in the
tests, we mock a `KinesisProxyInterface` and inject it into a `ShardConsumer`
under test through this constructor.
On the other hand, it'll be good to add tests related to error handling
across the new threads, in which case this constructor change can be left as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
