snuyanzin commented on code in PR #29285:
URL: https://github.com/apache/flink/pull/29285#discussion_r4106725552
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalJoinRuleBase.scala:
##########
@@ -153,6 +153,12 @@ trait BatchPhysicalJoinRuleBase {
!joinInfo.pairs().isEmpty
}
+ private def hasApplicableEquivJoinStrategy(join: Join, tableConfig:
TableConfig): Boolean = {
+ checkShuffleHash(join, tableConfig, withShuffleHashHint = false)._1 ||
+ checkSortMergeJoin(join, tableConfig) ||
Review Comment:
also probably makes sense to order these calls in way: cheapest first, the
most expensive last
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
