[ 
https://issues.apache.org/jira/browse/FLINK-34527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119507#comment-18119507
 ] 

Bhanu Chander Vallabaneni commented on FLINK-34527:
---------------------------------------------------

[~mapohl] gentle bump on this — you reported it and did the Java side in 
FLINK-32570, so you are probably the right person to ask.

Rather than leave it waiting on the API question I ended with, let me remove 
that as a blocker: unless you say otherwise I will accept *both* {{Duration}} 
and {{datetime.timedelta}} wherever {{Time}} is accepted today, and document 
{{Duration}} as the canonical one to mirror {{java.time.Duration}}. If you 
would rather it were {{Duration}} only, that is a smaller change and I am happy 
to do that instead — it is a one-line difference in the normalising helper, so 
correcting me later costs nothing.

I will open the PR as steps (1) and (2) only — accept the new types, deprecate 
{{Time}} and its factories — and leave migrating pyflink's own 32 internal 
usages and the docs samples to a follow-up, so the first review stays small.

Two things I cannot do myself: the ticket is still unassigned, so could you or 
another committer assign it to me. And if this is not wanted, or is already 
covered by work I have not found, please say and I will drop it rather than 
leave it sitting here.


> Deprecate Time classes also in PyFlink
> --------------------------------------
>
>                 Key: FLINK-34527
>                 URL: https://issues.apache.org/jira/browse/FLINK-34527
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Python
>    Affects Versions: 1.20.0
>            Reporter: Matthias Pohl
>            Priority: Major
>
> FLINK-32570 deprecated the Time classes. But we missed touched the 
> PyFlink-related APIs. Also the Docs should be checked for code samples 
> related to Time classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to