[
https://issues.apache.org/jira/browse/FLINK-40514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119601#comment-18119601
]
suntectec commented on FLINK-40514:
-----------------------------------
I'd like to work on this issue.
I verified the mismatch against the current master: auto-redirect is declared
as booleanType() in DorisDataSinkOptions but documented as String;
charset-encoding is stringType() with default "UTF-8" but documented as Boolean
with default false; the English sink.ignore.update-before row still contains
the leftover Java string concatenation; and sink.enable-2pc,
sink.check-interval, sink.buffer-size, sink.buffer-count, sink.label-prefix and
sink.use-cache are all declared in DorisDataSinkFactory#optionalOptions() but
missing from the option table.
The fix will update both
docs/content/docs/connectors/pipeline-connectors/doris.md and the Chinese
counterpart under docs/content.zh/, so the option tables match
DorisDataSinkOptions and DorisDataSinkFactory. No code change is involved.
~rango2017 thanks for the detailed write-up -- please let me know if you have
already started on this, so we don't duplicate the work.
> [Docs] Doris pipeline connector option table does not match implementation
> --------------------------------------------------------------------------
>
> Key: FLINK-40514
> URL: https://issues.apache.org/jira/browse/FLINK-40514
> Project: Flink
> Issue Type: Bug
> Components: Documentation, Flink CDC
> Affects Versions: cdc-3.6.0
> Reporter: Rango
> Priority: Minor
>
> The Doris pipeline connector option table in both
> {{docs/content/docs/connectors/pipeline-connectors/doris.md}}
> and the Chinese counterpart is out of sync with
> {{DorisDataSinkOptions}} / {{DorisDataSinkFactory}}.
> 1. {{charset-encoding}} is documented as Boolean with default {{false}}.
> The option is String with default {{UTF-8}}, and {{DorisMetadataApplier}}
> reads it via {{config.get(CHARSET_ENCODING)}}.
> 2. {{auto-redirect}} is documented as String. The option is Boolean.
> 3. The English description of {{sink.ignore.update-before}} still contains
> leftover Java string concatenation ({{"\n" + "}}).
> 4. These optional options exist in the factory but are not listed:
> {{sink.enable-2pc}}, {{sink.check-interval}}, {{sink.buffer-size}},
> {{sink.buffer-count}}, {{sink.label-prefix}}, {{sink.use-cache}}.
> I can update the English and Chinese option tables to match the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
