rmetzger commented on code in PR #29136:
URL: https://github.com/apache/flink/pull/29136#discussion_r4119620393
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -1627,15 +1627,27 @@ private JobsOverview getCompletedJobsOverview() {
@Override
public CompletableFuture<MultipleJobsDetails>
requestMultipleJobDetails(Duration timeout) {
- List<CompletableFuture<Optional<JobDetails>>>
individualOptionalJobDetails =
- queryJobMastersForInformation(
Review Comment:
Why is this fix not in `queryJobMastersForInformation`?
`requestClusterOverview` Is the only other method using
`queryJobMastersForInformation`.
I think both benefit from properly failing if the returned information is
incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
