SEPURI-SAI-KRISHNA commented on PR #209: URL: https://github.com/apache/flink-connector-jdbc/pull/209#issuecomment-5889137303
Thanks, all three look good on cd5ef6e. Re-ran my counter check against the new fake: 20/20 runs stay at 1 even after a 2s wait, where before it reached 2 within tens of milliseconds. (That number varied more than I said above, 19-72ms across runs, but the ordering was never enforced.) Deriving the fan-out from `maxPoolSize()` with the clamp, and making the pool size a `ConnectionOptions` setting, is better than what I suggested, and the 1/4/16/0 tests cover it. `readFully` in both paths. `flink-connector-jdbc-core` is green locally at that commit: 375 tests, no failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
