tchivs commented on code in PR #4530:
URL: https://github.com/apache/flink-cdc/pull/4530#discussion_r4140720242
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/data/RecordData.java:
##########
@@ -170,6 +170,16 @@ public interface RecordData {
/** Returns the Time data at the given position. */
TimeData getTime(int pos);
+ /**
+ * Returns the Time data at the given position using its declared
precision.
+ *
+ * <p>The default implementation preserves compatibility with record
implementations whose
+ * representation is independent of precision.
+ */
+ default TimeData getTime(int pos, int precision) {
+ return getTime(pos);
+ }
Review Comment:
Addressed: TIME now uses a single eight-byte layout at every precision, so
the getTime(int, int) addition is gone. RecordData is unchanged apart from the
layout table in its javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
