SEPURI-SAI-KRISHNA commented on PR #29183: URL: https://github.com/apache/flink/pull/29183#issuecomment-5916724107
Not a committer, just a review. Matches the precedent you cited, same shape as `IntermediateResultPartitionTest`. The second commit undoes the first, so the first message no longer describes what the PR does. Worth squashing. On the shape: `testFindLatestAllocationIgnoresFailedAttempts` stays on the pooled executor, and the inline instance is never shut down (`DirectScheduledExecutorService` holds a single-thread scheduled executor; `TestExecutorExtension#afterAll` normally shuts it). `IntermediateResultPartitionTest` does the same, so this is consistent, but swapping the class-level extension to `new TestExecutorExtension<>(DirectScheduledExecutorService::new)` covers both tests and keeps the shutdown, as FLINK-40682 did for `ArchivedExecutionGraphTest`. Deliberate? Haven't tried to reproduce the rate, at 5 in 12000 a local number wouldn't mean much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
