raminqaf commented on code in PR #29343:
URL: https://github.com/apache/flink/pull/29343#discussion_r4152565106
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ParseJsonFunction.java:
##########
@@ -38,8 +38,9 @@ public
ParseJsonFunction(SpecializedFunction.SpecializedContext context) {
return eval(jsonStr, false);
}
- public @Nullable Variant eval(@Nullable StringData jsonStr, boolean
allowDuplicateKeys) {
- if (jsonStr == null) {
+ public @Nullable Variant eval(
+ @Nullable StringData jsonStr, @Nullable Boolean
allowDuplicateKeys) {
+ if (jsonStr == null || allowDuplicateKeys == null) {
Review Comment:
I think failing (since I don't see a semantic of `allowDuplicates=null`) or
falling back to `false` would be a better behavior for the end user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
