[ 
https://issues.apache.org/jira/browse/FLINK-40789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18121542#comment-18121542
 ] 

Martijn Visser commented on FLINK-40789:
----------------------------------------

Same extra rescale in testRescaleTerminatedByJobCancelled on release-2.3, 
nightly 2026-10-01 (test_ci core, JDK 17):
https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79631&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1

{code}
[ERROR] 
org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.testRescaleTerminatedByJobCancelled
 -- Time elapsed: 10.82 s <<< ERROR!
java.util.concurrent.TimeoutException: Condition was not met within 10000 ms.
        at 
org.apache.flink.core.testutils.CommonTestUtils.waitUtil(CommonTestUtils.java:218)
        at 
org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.waitUntilConditionWithTimeout(RescaleTimelineITCase.java:698)
        at 
org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.testRescaleTerminatedByJobCancelled(RescaleTimelineITCase.java:325)
{code}

The test waits for two rescales with the latest terminated by JOB_CANCELED. The 
job was first scheduled at parallelism 2 here too, so the fork log has three:

{code}
Rescale{... rescaleAttemptId=1}, ... postRescaleParallelism=2 ... 
triggerCause=INITIAL_SCHEDULE, terminalState=COMPLETED, 
terminatedReason=SUCCEEDED}
Rescale{... rescaleAttemptId=2}, ... preRescaleParallelism=2 ... 
triggerCause=NEW_RESOURCE_AVAILABLE, terminalState=IGNORED, 
terminatedReason=RESOURCE_REQUIREMENTS_UPDATED}
Rescale{... rescaleAttemptId=1}, ... preRescaleParallelism=2 ... 
triggerCause=UPDATE_REQUIREMENT, terminalState=IGNORED, 
terminatedReason=JOB_CANCELED}
{code}
```

> RescaleTimelineITCase.testRecordRescaleForNewAvailableResource records three 
> rescales instead of two
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-40789
>                 URL: https://issues.apache.org/jira/browse/FLINK-40789
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 2.4.0
>            Reporter: Martijn Visser
>            Priority: Major
>
> https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79368&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1
>  (master push 2026-09-23, test_ci core, JDK 17)
> {code}
> [ERROR] 
> org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.testRecordRescaleForNewAvailableResource
>  -- Time elapsed: 0.722 s <<< FAILURE!
> java.lang.AssertionError:
> Expected size: 2 but was: 3 in:
> [Rescale{... rescaleAttemptId=3, ... preRescaleParallelism=4, 
> postRescaleParallelism=6 ... triggerCause=NEW_RESOURCE_AVAILABLE, 
> terminalState=COMPLETED ...},
>     Rescale{... rescaleAttemptId=2, ... preRescaleParallelism=2, 
> postRescaleParallelism=4 ... triggerCause=NEW_RESOURCE_AVAILABLE, 
> terminalState=COMPLETED ...},
>     Rescale{... rescaleAttemptId=1, ... preRescaleParallelism=null, 
> postRescaleParallelism=2 ... triggerCause=INITIAL_SCHEDULE, 
> terminalState=COMPLETED ...}]
>         at 
> org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.lambda$testRecordRescaleForNewAvailableResource$2(RescaleTimelineITCase.java:170)
>         at 
> org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.runAdaptedParameterizedAssertion(RescaleTimelineITCase.java:397)
>         at 
> org.apache.flink.runtime.scheduler.adaptive.timeline.RescaleTimelineITCase.testRecordRescaleForNewAvailableResource(RescaleTimelineITCase.java:164)
> {code}
>                                                                               
>                                                                               
>                    The test expects the initial schedule at parallelism 4 and 
> one upscale to 6 after the third TaskManager starts. Here the job was first 
> scheduled at 2 and went 2 -> 4 -> 6. The other RescaleTimelineITCase methods 
> had similar races fixed in FLINK-40010, FLINK-40067 and FLINK-40076; this 
> method has no ticket.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to