mateczagany commented on code in PR #257:
URL:
https://github.com/apache/flink-connector-aws/pull/257#discussion_r4165676325
##########
docs/content/docs/connectors/datastream/kinesis.md:
##########
@@ -99,6 +115,36 @@ val kinesisEvents = env.fromSource(kdsSource,
WatermarkStrategy.forMonotonousTim
.uid("custom-uid")
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+from pyflink.common import Configuration, WatermarkStrategy, Duration
+from pyflink.common.serialization import SimpleStringSchema
+from pyflink.datastream import StreamExecutionEnvironment
+from pyflink.datastream.connectors import KinesisStreamsSource,
KinesisShardAssigner
+
+# Configure the KinesisStreamsSource
+source_config = Configuration()
+# source_config.set_string("flink.stream.initpos", "TRIM_HORIZON") #
Optional, default is LATEST
Review Comment:
If I'm not mistaken, it's `source.init.position` instead of
`flink.stream.initpos`
##########
docs/content/docs/connectors/datastream/kinesis.md:
##########
@@ -99,6 +115,36 @@ val kinesisEvents = env.fromSource(kdsSource,
WatermarkStrategy.forMonotonousTim
.uid("custom-uid")
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+from pyflink.common import Configuration, WatermarkStrategy, Duration
+from pyflink.common.serialization import SimpleStringSchema
+from pyflink.datastream import StreamExecutionEnvironment
+from pyflink.datastream.connectors import KinesisStreamsSource,
KinesisShardAssigner
Review Comment:
Aren't these imported from `pyflink.datastream.connectors.kinesis` instead?
##########
.github/workflows/publish-python.yml:
##########
@@ -0,0 +1,122 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Python Package to PyPI
+
+on:
+ release:
+ types: [published]
+ workflow_dispatch:
+ inputs:
+ dry_run:
+ description: 'Dry run (build but do not publish)'
Review Comment:
I think the description and name `dry_run` is a bit misleading, as it will
still publish the package, just to TestPyPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
