snuyanzin commented on code in PR #29365:
URL: https://github.com/apache/flink/pull/29365#discussion_r4167222267
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java:
##########
@@ -142,6 +142,10 @@ public static InputTypeStrategy plainJsonPath(final
InputTypeStrategy signatures
public static final InputTypeStrategy FROM_CHANGELOG_INPUT_TYPE_STRATEGY =
FromChangelogTypeStrategy.INPUT_TYPE_STRATEGY;
+ /** Input strategy for {@link
BuiltInFunctionDefinitions#DEDUPLICATE_KEEP_FIRST}. */
+ public static final InputTypeStrategy DEDUPLICATE_KEEP_FIRST_TYPE_STRATEGY
=
Review Comment:
```suggestion
public static final InputTypeStrategy
DEDUPLICATE_KEEP_FIRST_INPUT_TYPE_STRATEGY =
```
please follow existing pattern in namings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
