snuyanzin commented on code in PR #29341: URL: https://github.com/apache/flink/pull/29341#discussion_r4182129186
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/codegen/XmlCodeGenUtils.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.codegen; + +import org.apache.flink.table.planner.utils.JavaScalaConversionUtil; +import org.apache.flink.table.runtime.functions.SqlXmlUtils; +import org.apache.flink.table.runtime.functions.XmlToVariantParser; +import org.apache.flink.table.types.logical.LogicalType; + +import java.util.Collections; + +import scala.Option; +import scala.Tuple2; +import scala.collection.Seq; + +/** + * Code generation of {@code PARSE_XML} and {@code TRY_PARSE_XML}. + * + * <p>The calls on the same input share the read document, so that each document is read once per + * record. For example, {@code SELECT PARSE_XML(xml)['a'], PARSE_XML(xml, TRUE), TRY_PARSE_XML(xml) + * FROM t} generates code similar to: + * + * <pre>{@code + * // members + * private final XmlToVariantParser xmlParser$0 = new XmlToVariantParser(); + * SqlXmlUtils.ReadXml xmlDocument$1; + * BinaryStringData xmlInput$2; + * + * private SqlXmlUtils.ReadXml readXml$3(BinaryStringData in) { + * if (in != xmlInput$2) { + * xmlInput$2 = in; + * xmlDocument$1 = SqlXmlUtils.read(xmlParser$0, in); + * } + * return xmlDocument$1; + * } + * + * // calls + * result$4 = SqlXmlUtils.parseXml(readXml$3(field$0), false); + * result$5 = SqlXmlUtils.parseXml(readXml$3(field$0), true); + * result$6 = SqlXmlUtils.tryParseXml(readXml$3(field$0), false); Review Comment: does it mean we call `readXml$3(field$0)` 3 times here (3 times xml parse)? can we extract it into a var and call just once? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
