kotwal-itpro opened a new pull request, #29393:
URL: https://github.com/apache/flink/pull/29393
## What is the purpose of the change
`SELECT 1 / (2 + 3)` fails during optimization with a ClassCastException.
`ExpressionReducer` checks constant divisions for a zero divisor and casts the
divisor to `RexLiteral`, but the divisor can be an unreduced constant
expression.
## Brief change log
- Only check literal divisors for zero. Other constant divisors are
evaluated with the division; an evaluation failure already falls back to
executing the expression unreduced.
## Verifying this change
- Added `1 / (2 + 3)`, `6 / (2 * 3)` and `1.0 / (2 * 3)` to
`SqlExpressionTest#testDivideFunctions`. They fail with the reported
ClassCastException without the fix.
- Existing division-by-zero cases (`1/0`, `1/cast(0 as bigint)`, ...) still
raise "Division by zero".
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
