AHeise commented on code in PR #29385:
URL: https://github.com/apache/flink/pull/29385#discussion_r4194636691


##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-table-source-scan_2/table-source-scan-filter-pushdown-on-collection-elements/plan/table-source-scan-filter-pushdown-on-collection-elements.json:
##########
@@ -0,0 +1,163 @@
+{
+  "flinkVersion" : "2.4",
+  "nodes" : [ {
+    "id" : 1,
+    "type" : "stream-exec-table-source-scan_2",
+    "scanTableSource" : {
+      "table" : {
+        "identifier" : "`default_catalog`.`default_database`.`source_t`",
+        "resolvedTable" : {
+          "schema" : {
+            "columns" : [ {
+              "name" : "a",
+              "dataType" : "INT"
+            }, {
+              "name" : "arr",
+              "dataType" : "ARRAY<INT>"
+            }, {
+              "name" : "m",
+              "dataType" : "MAP<VARCHAR(2147483647), INT>"
+            }, {
+              "name" : "v",
+              "dataType" : "VARIANT"
+            } ]
+          }
+        }
+      },
+      "abilities" : [ {
+        "type" : "FilterPushDown",
+        "predicates" : [ {
+          "kind" : "CALL",
+          "syntax" : "BINARY",
+          "internalName" : "$>$1",
+          "operands" : [ {
+            "kind" : "CALL",
+            "syntax" : "SPECIAL",
+            "internalName" : "$ITEM$1",
+            "operands" : [ {
+              "kind" : "INPUT_REF",
+              "inputIndex" : 1,
+              "type" : "ARRAY<INT>"
+            }, {
+              "kind" : "LITERAL",
+              "value" : 1,
+              "type" : "INT NOT NULL"
+            } ],
+            "type" : "INT"
+          }, {
+            "kind" : "LITERAL",
+            "value" : 1,
+            "type" : "INT NOT NULL"
+          } ],
+          "type" : "BOOLEAN"
+        }, {
+          "kind" : "CALL",
+          "syntax" : "BINARY",
+          "internalName" : "$>$1",
+          "operands" : [ {
+            "kind" : "CALL",
+            "syntax" : "SPECIAL",
+            "internalName" : "$ITEM$1",
+            "operands" : [ {
+              "kind" : "INPUT_REF",
+              "inputIndex" : 2,
+              "type" : "MAP<VARCHAR(2147483647), INT>"
+            }, {
+              "kind" : "LITERAL",
+              "value" : "k",
+              "type" : "CHAR(1) NOT NULL"
+            } ],
+            "type" : "INT"
+          }, {
+            "kind" : "LITERAL",
+            "value" : 1,
+            "type" : "INT NOT NULL"
+          } ],
+          "type" : "BOOLEAN"
+        }, {
+          "kind" : "CALL",
+          "syntax" : "BINARY",
+          "internalName" : "$>$1",
+          "operands" : [ {
+            "kind" : "CALL",
+            "syntax" : "SPECIAL",
+            "internalName" : "$CAST$1",
+            "operands" : [ {
+              "kind" : "CALL",
+              "syntax" : "SPECIAL",
+              "internalName" : "$ITEM$1",
+              "operands" : [ {
+                "kind" : "INPUT_REF",
+                "inputIndex" : 3,
+                "type" : "VARIANT"
+              }, {
+                "kind" : "LITERAL",
+                "value" : "k",
+                "type" : "CHAR(1) NOT NULL"
+              } ],
+              "type" : "VARIANT"
+            } ],
+            "type" : "INT"
+          }, {
+            "kind" : "LITERAL",
+            "value" : 1,
+            "type" : "INT NOT NULL"
+          } ],
+          "type" : "BOOLEAN"
+        } ]
+      }, {
+        "type" : "ProjectPushDown",
+        "projectedFields" : [ [ 0 ] ],
+        "producedType" : "ROW<`a` INT> NOT NULL"
+      }, {
+        "type" : "ReadingMetadata",
+        "metadataKeys" : [ ],

Review Comment:
   Yes, looks like we generate such an empty step for all sources that _may_ 
read metadata. If we drop that in a follow up ticket, we need to regenerate 
lots of plans :/.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to