MartijnVisser commented on code in PR #29383:
URL: https://github.com/apache/flink/pull/29383#discussion_r4194899399


##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointSyncPhaseTimeoutITCase.java:
##########
@@ -68,7 +67,7 @@ private static StreamExecutionEnvironment envSetup() {
 
     @Test
     void testStuckSyncPhaseFailsJob(@InjectMiniCluster MiniCluster 
miniCluster) throws Exception {
-        env.addSource(new BlockingSnapshotSource()).sinkTo(new 
DiscardingSink<>());
+        env.addOperator(env.addSource(new 
BlockingSnapshotSource()).getTransformation());

Review Comment:
   Might be worth a short comment on why this job has no sink, so nobody adds 
one back later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to