seungjoo-choi-bucketplace commented on PR #29169: URL: https://github.com/apache/flink/pull/29169#issuecomment-6027325380
Rebased onto master now that FLINK-40644 (#29168) is in. As expected, the two changes met in `CachedDataInputStream#close()`. Resolution: the unregistration goes **before** both closes. ```java closed = true; cacheEntry.unregisterStream(this); // this PR // FLINK-40644: close the cached stream and the original one, keeping the // first exception and attaching the second as suppressed ``` This actually strengthens the invariant — previously only a failing `closeCachedStream()` could not skip the removal, now a failing `originalStream.close()` cannot either. Comment wording updated from "before `closeCachedStream()`" to "before the closes below". No other change: the diff against master is purely additive (+5 in `CachedDataInputStream`, +13 in `FileCacheEntry`, +162 in `FileCacheEntryTest`). Both existing tests stay valid — the cached-stream double is the only one that throws on close, the original stream double is a no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
