snuyanzin commented on code in PR #29415:
URL: https://github.com/apache/flink/pull/29415#discussion_r4206337502
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PushProjectIntoTableSourceScanRule.java:
##########
@@ -200,6 +199,11 @@ private boolean
supportsProjectionPushDown(DynamicTableSource tableSource) {
return tableSource instanceof SupportsProjectionPushDown;
}
+ private static boolean hasReadingMetadataSpec(TableSourceTable source) {
+ return Arrays.stream(source.abilitySpecs())
+ .anyMatch(spec -> spec instanceof ReadingMetadataSpec);
+ }
+
private boolean supportsMetadata(DynamicTableSource tableSource) {
Review Comment:
nit: since you are here probably `supportsMetadata` and
`supportsProjectionPushDown` above could be also static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
