snuyanzin commented on code in PR #29411:
URL: https://github.com/apache/flink/pull/29411#discussion_r4207094300
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java:
##########
@@ -257,6 +257,17 @@ public static boolean areComparable(
firstType.copy(true), secondType.copy(true),
requiredComparison);
}
+ /**
+ * Checks whether values of a (possibly nested) logical type can be used
as grouping, join,
+ * partition or sort keys and as operands of comparison operators.
+ *
+ * <p>VARIANT is not a comparable key type, because one VARIANT value has
many valid binary
+ * encodings.
+ */
+ public static boolean isComparableKeyType(LogicalType logicalType) {
Review Comment:
why do we need one more comparable method instead of reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
