davidradl commented on code in PR #29416:
URL: https://github.com/apache/flink/pull/29416#discussion_r4209413215
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/CommonCollectionInputTypeStrategyTest.java:
##########
@@ -24,12 +24,48 @@
import java.util.stream.Stream;
+import static
org.apache.flink.table.types.inference.strategies.SpecificInputTypeStrategies.MAPS_KEYS_EQUALS_COMPARABLE;
+import static
org.apache.flink.table.types.inference.strategies.SpecificInputTypeStrategies.TWO_ARRAYS_EQUALS_COMPARABLE;
+
/** Tests for {@link CommonCollectionInputTypeStrategy}. */
class CommonCollectionInputTypeStrategyTest extends
InputTypeStrategiesTestBase {
@Override
protected Stream<TestSpec> testData() {
return Stream.of(
+ TestSpec.forStrategy(
+ "Common array type with element equality",
+ TWO_ARRAYS_EQUALS_COMPARABLE)
+ .expectSignature("f(<COMMON>, <COMMON>)")
+ .calledWithArgumentTypes(
+ DataTypes.ARRAY(DataTypes.INT()),
+ DataTypes.ARRAY(DataTypes.BIGINT()))
+ .expectArgumentTypes(
+ DataTypes.ARRAY(DataTypes.BIGINT()),
+ DataTypes.ARRAY(DataTypes.BIGINT())),
+ TestSpec.forStrategy(
+ "Common array type without element equality",
+ TWO_ARRAYS_EQUALS_COMPARABLE)
+ .calledWithArgumentTypes(
+ DataTypes.ARRAY(DataTypes.VARIANT()),
+ DataTypes.ARRAY(DataTypes.VARIANT()))
+ .expectErrorMessage(
+ "Type 'VARIANT' should support 'EQUALS'
comparison with itself."),
Review Comment:
nit: I am not sure what this expected error message means. should be
something like "Type 'VARIANT' does not support 'EQUALS' comparison with
itself."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
