ykisana opened a new pull request, #29426:
URL: https://github.com/apache/flink/pull/29426
## What is the purpose of the change
`EarlyFireJoinHintTest.testEarlyFireProcTimeOnRowTimeJoin` fails on master.
Its plan was recorded by FLINK-40172 while table source scans still printed an
empty `metadata=[]`. FLINK-38569 stopped recording the empty
`ReadingMetadataSpec` and regenerated the other cases in
`EarlyFireJoinHintTest.xml`, but its branch predated this case, so the two
commits only conflict after both landed. The planner output is correct; only
the expected plan is stale.
## Brief change log
- Remove `, metadata=[]` from the two `TableSourceScan` lines of
`testEarlyFireProcTimeOnRowTimeJoin` in `EarlyFireJoinHintTest.xml`
## Verifying this change
This change is already covered by existing tests, such as
`EarlyFireJoinHintTest`. On master `7a76f129672`,
`testEarlyFireProcTimeOnRowTimeJoin` fails (1 of 18). With this change, all 18
tests pass.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated by: Claude Opus 5.5
Fix and tests written by Claude; all code manually reviewed by @ykisana.
PR description by Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
