weiqingy opened a new pull request, #29428:
URL: https://github.com/apache/flink/pull/29428
Fixes a broken `master`. No JIRA, per the template's exemption for changes
of this kind.
## What is the purpose of the change
`EarlyFireJoinHintTest.testEarlyFireProcTimeOnRowTimeJoin` fails on
`master`, reported in #28953.
FLINK-38569 (`8171d96a94e`) stopped recording a `ReadingMetadata` ability
when no metadata key is projected, so scan digests no longer render
`metadata=[]`, and it updated every golden plan accordingly, including 28 lines
of `EarlyFireJoinHintTest.xml`.
FLINK-40172 (`3fc308453a4`) merged about three hours earlier and added a new
case to that same file. The sweep therefore ran against a base where
`testEarlyFireProcTimeOnRowTimeJoin` did not exist, so its two
`TableSourceScan` lines kept the empty spec. Both changes were green on their
own base, which is why neither CI run caught it.
## Brief change log
- Drop `metadata=[]` from the two `TableSourceScan` lines in the
`testEarlyFireProcTimeOnRowTimeJoin` golden. This is the same edit the
FLINK-38569 sweep applied to the eight sibling cases in the file, which leaves
zero occurrences of the empty spec in it.
## Verifying this change
This change is already covered by existing tests.
- `EarlyFireJoinHintTest` fails 1 of 18 on `9bf67dddaa9` and passes 18 of
18 with this commit.
- `IntervalJoinTest` (28) and `IntervalJoinRestoreTest` (4) also run
green, confirming no other early-fire golden carries the stale spec.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no (test resource only)
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Anthropic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
