patrashu commented on code in PR #234:
URL:
https://github.com/apache/flink-connector-jdbc/pull/234#discussion_r4216001071
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/splitter/AbstractDynamicSplitterEnumerator.java:
##########
@@ -0,0 +1,124 @@
+ /*
Review Comment:
Hi, @och5351
I just fixed my code.
Root cause: mvn spotless:apply was run locally under JDK 25 (Homebrew's
default mvn picks it up). The root pom.xml has a java21 profile that sets
spotless.skip=true whenever the active JDK is 21 or newer — this exists because
google-java-format formats code differently on JDK 21+, so the project disables
Spotless entirely above JDK 20 to avoid that drift. Because of this, every
local spotless:apply/spotless:check run silently no-opped ("Spotless check
skipped") and never actually touched the files. The project's real CI
(push_pr.yml) only tests JDK 17, so the format violations were invisible
locally but would (and did) show up against the actual CI baseline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
