davidradl commented on PR #56:
URL:
https://github.com/apache/flink-connector-http/pull/56#issuecomment-6057811838
@AHeise thanks for the contribution.
So we are issuing a lookup join, we only expect a row if there is a match -
there is no a match, no response or there is an error we cannot tell the
difference so we treat that as a non match. In this way we only get enrichment
rows for the API table when there is something there. It would be unexpected
for our user to see rows if there were errors. This is our main use case.
If our user wants to see the complete rows then they can use a LEFT join.
The left join allows the user to get rows back in all error cases. The Null
enrichment rows are provided by the Flink framework.
The copy change looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
