fhueske commented on code in PR #29368:
URL: https://github.com/apache/flink/pull/29368#discussion_r4216695749
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/JoinOperationFactory.java:
##########
@@ -80,15 +80,29 @@ private void validateCondition(
JoinType joinType,
ResolvedExpression condition,
boolean correlated) {
- boolean alwaysTrue = ExpressionUtils.extractValue(condition,
Boolean.class).orElse(false);
-
- if (alwaysTrue) {
+ final boolean alwaysTrue =
+ ExpressionUtils.extractValue(condition,
Boolean.class).orElse(false);
+
+ // A lateral SNAPSHOT join is rewritten into a dedicated join that
supports an ON predicate
Review Comment:
Yes, makes sense.
But we still need a change to skip the LEFT OUTER / ON check for SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
