Admaing commented on PR #253: URL: https://github.com/apache/flink-connector-jdbc/pull/253#issuecomment-6094726491
Thanks @MartijnVisser, all three addressed in 4cb6d9f. First batch (inline 1): TemplateSqlSplitEnumeratorProvider.create() now falls back to parameterValuesProvider.getLatestOptionalState() when no state is set, so the first-batch checkpoint is no longer null. Added testSetSqlProviderSeedsStateFromProviderWhenNoStateIsConfigured and testFirstBatchOfSetSqlSourceIsReEnumeratedAfterRestore. Concurrency (inline 2): Dropped the completion-order assumption; preDiscoverSplits() now keeps at most one enumeration in flight (asyncCallsPending.get() < 1). Added testAtMostOneEnumerationIsInFlight; also fixed the comment and commit message. Test (inline 3): The next callable now runs before the in-flight snapshot, so the splitter has advanced to 2 and the assertion still expects state 1. Fails without the fix. Squashed into the single commit; tests, spotless and checkstyle pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
