bladedragon commented on code in PR #29303:
URL: https://github.com/apache/flink/pull/29303#discussion_r4241286739
##########
flink-python/pyflink/table/expression.py:
##########
@@ -1579,10 +1579,22 @@ def repeat(self, n: Union[int, 'Expression[int]']) ->
'Expression[str]':
"""
return _binary_op("repeat")(self, n)
- def over(self, alias) -> 'Expression':
+ def over(
+ self,
+ alias_or_order_by=None,
Review Comment:
Sure, that sounds like a better approach. I’ll restore alias as the
parameter name so over(alias=...) remains backward-compatible. Inline windows
will use the explicit order_by= keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
