weiqingy commented on PR #1215: URL: https://github.com/apache/flink-agents/pull/1215#issuecomment-6111716639
Thanks for the review. All four points are in, and main is merged to clear the conflicts (62906bd). 1. **Keyword-only `chat`** (d95f5b8). `chat_explicit` is gone. Python now has `chat(messages, prompt_args=None, *, tools=None, output_schema=None, **kwargs)`. Passing `tools` (even `[]`) sends the messages and tools as given; leaving it out prepares the request as before. `prompt_args` together with `tools` raises, since that path skips the bound prompt and would drop them silently. A call with only `output_schema` still takes the prepared path, so #843's routing is unchanged. `JavaChatModelSetup.chat` raises `NotImplementedError` for `tools` or `output_schema`, which mirrors the Java `PythonChatModelSetup` refusal. The test setups that override `chat(messages, **kwargs)` needed no change, since none of them is reached with tools or a schema. 2. Kept as is, thanks. 3. **Schema fields in the ReAct loop** (68e93bb). On the native path the loop prompt now reads "The final response must include the information for every required field of the following schema. It does not need to be in JSON format.", followed by the schema. It is a second prompt resource placed where the JSON instruction goes, so the two paths differ only in wording. The conversion directive is unchanged and still forbids adding or inferring information. One limit: Python shows field descriptions and the `required` list, but Java POJO schemas show neither, because Jackson's schema generator drops descriptions and marks a field required only with `@JsonProperty(required = true)`. The JSON prompt on main has the same gap, so I left it out of this PR. 4. **Follow-up:** #1222. One question for that issue: when a connection reports it can take tools and the schema together, should `AUTO` use the single-call path by default, or should that path be opt-in, since it changes every loop request rather than only the final one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
