[ 
https://issues.apache.org/jira/browse/FLINK-40988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser updated FLINK-40988:
-----------------------------------
    Description: 
We should bump JUnit from 5.11.4 to 5.14.4. That is the last 5.x release, since 
JUnit 6 requires Java 17 and we still support Java 11.

Among others this adds {{@ParameterizedClass}}, which runs every test method in 
a class once per parameter set 
https://docs.junit.org/5.14.0/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedClass.html.
 That makes it a better fit for new parameterized tests than our own 
{{ParameterizedTestExtension}}, where a plain {{@Test}} silently runs only once 
(see FLINK-40971). Migrating existing tests is out of scope.

{{JUnit5TestEnvironment}} implements {{ExtensionContext}} itself and needs the 
methods added since 5.11. JUnit 5.14 also warns about private lifecycle methods 
in a few flink-runtime tests, which will be disallowed in a future release.

  was:
We should bump JUnit from 5.11.4 to 5.14.4. That is the last 5.x release, since 
JUnit 6 requires Java 17 and we still support Java 11.

Among others this adds {{@ParameterizedClass}}, which runs every test method in 
a class once per parameter set 
https://docs.junit.org/5.14.0/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedClass.html.
 That makes it a better fit for new parameterized tests than our own 
{{ParameterizedTestExtension}}, where a plain {{@Test}} silently runs only once 
(see FLINK-40971). Migrating existing tests is out of scope for this ticket.


> Bump JUnit to 5.14
> ------------------
>
>                 Key: FLINK-40988
>                 URL: https://issues.apache.org/jira/browse/FLINK-40988
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Test Infrastructure
>            Reporter: Martijn Visser
>            Assignee: Martijn Visser
>            Priority: Major
>
> We should bump JUnit from 5.11.4 to 5.14.4. That is the last 5.x release, 
> since JUnit 6 requires Java 17 and we still support Java 11.
> Among others this adds {{@ParameterizedClass}}, which runs every test method 
> in a class once per parameter set 
> https://docs.junit.org/5.14.0/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedClass.html.
>  That makes it a better fit for new parameterized tests than our own 
> {{ParameterizedTestExtension}}, where a plain {{@Test}} silently runs only 
> once (see FLINK-40971). Migrating existing tests is out of scope.
> {{JUnit5TestEnvironment}} implements {{ExtensionContext}} itself and needs 
> the methods added since 5.11. JUnit 5.14 also warns about private lifecycle 
> methods in a few flink-runtime tests, which will be disallowed in a future 
> release.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to