[ 
https://issues.apache.org/jira/browse/FLINK-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timo Walther updated FLINK-5714:
--------------------------------
    Description: 
Right now, the constructor of the CsvTableSource can have up to 9 parameters. 
In Scala this might not be a problem because of default values, but Java 
doesn't have this functionality.

I propose to have a a builder pattern here:

{code}
CsvTableSource
.builder()
.field("myfield", Types.STRING)
.field("myfield2", Types.INT)
.quoteCharacter(';')
.build()
{code}

  was:
Right now, the constructor of the CsvTableSource can have up to 9 parameters. 
In Scala this might not be a problem because of default values, but Java 
doesn't has this functionality.

I propose to have a a builder pattern here:

{code}
CsvTableSource
.builder()
.field("myfield", Types.STRING)
.field("myfield2", Types.INT)
.quoteCharacter(';')
.build()
{code}


> Use a builder pattern for creating CsvTableSource
> -------------------------------------------------
>
>                 Key: FLINK-5714
>                 URL: https://issues.apache.org/jira/browse/FLINK-5714
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>
> Right now, the constructor of the CsvTableSource can have up to 9 parameters. 
> In Scala this might not be a problem because of default values, but Java 
> doesn't have this functionality.
> I propose to have a a builder pattern here:
> {code}
> CsvTableSource
> .builder()
> .field("myfield", Types.STRING)
> .field("myfield2", Types.INT)
> .quoteCharacter(';')
> .build()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to