loserwang1024 commented on code in PR #4523:
URL: https://github.com/apache/flink-cdc/pull/4523#discussion_r4268286263
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/reader/PostgresSourceReader.java:
##########
@@ -65,6 +65,13 @@ public class PostgresSourceReader extends
IncrementalSourceReaderWithCommit {
private final PriorityQueue<Long> minHeap;
private final int lsnCommitCheckpointsDelay;
+ /**
+ * Kept locally because {@link IncrementalSourceReader} holds its copy
privately, and {@link
+ * #onSplitFinished} needs it to tell a suspended stream split apart from
one that reached its
+ * ending offset.
+ */
+ private final IncrementalSourceReaderContext
incrementalSourceReaderContext;
Review Comment:
Now that dialect and sourceConfig is already `protected`,
incrementalSourceReaderContext can also be modified as `protected`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
