snuyanzin commented on code in PR #29481:
URL: https://github.com/apache/flink/pull/29481#discussion_r4273473249
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##########
@@ -1955,16 +1955,15 @@ object ScalarOperatorGens {
val leftMapTerm = newName(ctx, "leftMap")
val leftKeyTerm = newName(ctx, "leftKey")
- val leftValueTerm = newName(ctx, "leftValue")
- val leftValueNullTerm = newName(ctx, "leftValueIsNull")
+ // Map values are boxed. Unbox them, otherwise generateEquals compares
the boxes by reference.
+ val leftBoxedValueTerm = newName(ctx, "leftBoxedValue")
val leftValueExpr =
Review Comment:
why do we need to do autoboxing/unboxing here?
can we instead have map key to index and then retrieve values by index and
use for instance `getInt` or other types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
