SEPURI-SAI-KRISHNA commented on PR #29476: URL: https://github.com/apache/flink/pull/29476#issuecomment-6174381935
Had a look while it is in draft. One suggestion, one minor note. `JUnit5TestEnvironment` line 505: the stub store's `close()` only closes `CloseableResource`, and there is no other handling in the file. The real store also closes `AutoCloseable`, unless `junit.jupiter.extensions.store.close.autocloseable.enabled` is false, and `CloseableResource` is deprecated since 5.13 in favour of extending `AutoCloseable` directly. Nothing leaks today: of the extensions these tests register, only `ParameterizedTestExtension` uses the store, and it keeps parameter values and `Field` objects. Still worth handling both while the file is being updated for 5.14. Minor, separate from this PR: `MiniClusterExtension` line 307 implements `ExtensionContext.Store.CloseableResource`, which this bump turns into deprecated API. On not having run flink-yarn-tests: for the private lifecycle part at least, a scan of every Java file at master 371ba17 finds 17 such methods across exactly the 8 files you changed, so flink-runtime is the whole of it. `junit-bom` is also driven by `junit5.version` and no pom declares a `junit-platform` artifact or its own platform property, so jupiter, vintage and the platform jars they pull in all follow the one bump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
