ykisana commented on code in PR #29483:
URL: https://github.com/apache/flink/pull/29483#discussion_r4275703240
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/codegen/JsonParseReuseTest.java:
##########
@@ -509,4 +531,53 @@ void testJsonValueAfterSkippedJsonTypeIsResetPerRow() {
.as("JSON_TYPE + JSON_VALUE on the same input should parse
once")
.isOne();
}
+
+ @Test
Review Comment:
I would add a stronger test here too, maybe a test could feed invalid JSON
to SELECT TRY_PARSE_JSON(x), PARSE_JSON(x) and check that, the TRY call returns
NULL, and the query still fails because of PARSE_JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
