weiqingy commented on issue #1256: URL: https://github.com/apache/flink-agents/issues/1256#issuecomment-6208389188
@sangkyoonnam Thanks for taking this. Your two-step split matches the issue. GitHub only lets me assign people who have commented on the issue, so please leave a comment here and I'll assign it to you. Pointers for the first step: - The prompt text is built in `ReActAgent` (Java, `outputSchema.toString()`) and `react_agent.py` (Python, `str(output_schema)`). The same string feeds both the schema prompt and the native-schema prompt. - Please render the same JSON Schema for the same row type in both languages, with a test on each side. - The response becomes a `Row` in `ChatModelAction.generateStructuredOutput` (Java) and `_generate_structured_output` (Python). Both copy the JSON values without converting them to the field types, and a missing field gives `null` in Java but a `KeyError` in Python. That can stay out of scope, but a test that checks field types may run into it. For the second step: #1266 moves the six Python `_native_output_model` copies into one helper, and the native step changes that same check. Whichever lands first, the other can rebase onto it. Happy to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
