[ 
https://issues.apache.org/jira/browse/FLINK-40970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18127891#comment-18127891
 ] 

Yuepeng Pan commented on FLINK-40970:
-------------------------------------

Thanks [~martijnvisser] for creating the ticket and [~psinha] for the attention.



 

I have previously done some analysis (mainly divided into the following steps), 
hoping it can provide some reference for breaking down our remaining work:
 * Migrate the remaining test classes running on JUnit4 in flink-test-utils
 * Migrate the remaining test classes running on JUnit4 in 
flink-statebackend-changelog
 * Migrate the remaining test classes running on JUnit4 in flink-runtime, and 
remove the deprecated TestingFatalErrorHandlerResource
 * Migrate the remaining test classes running on JUnit4 in flink-table-runtime
 * Remove AbstractTestBaseJUnit4, JavaProgramTestBaseJUnit4, 
MultipleProgramsTestBaseJUnit4
 * Remove references to org.apache.flink.util.TestLogger
 * Mark the RetryRule class as deprecated, or even delete it.

BTW, It may still be a good choice to complete these remaining tasks at the 
granularity of JIRA issues.

This is mainly for the purpose of facilitating collaboration, including:

 ** It helps multiple contributors to jointly advance this work
 ** It facilitates efficient final review by reviewers, because the larger the 
scope of changes and impact, the more time investment is required. Even with AI 
assistance, manual verification as the final safeguard remains an indispensable 
part.

Please let me know your opinion. Thank you very much.

> [JUnit5 Migration] Migrate the JUnit 4 tests not covered by other subtasks
> --------------------------------------------------------------------------
>
>                 Key: FLINK-40970
>                 URL: https://issues.apache.org/jira/browse/FLINK-40970
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Martijn Visser
>            Priority: Major
>
> A few tests still run on JUnit 4 without any open subtask covering them, 
> either because they were missed or because they were added after their 
> package was migrated:
> * {{ContextStateFutureImplTest}}, {{JobInitializationMetricsTest}}, 
> {{SubTaskInitializationMetricsTest}}, {{DoubleAccumulatorTest}}, 
> {{FileMergingCheckpointStateOutputStreamTest}}, 
> {{FsSegmentDataInputStreamTest}} and {{WatermarkSamplerTest}} in flink-runtime
> * {{AsyncLookupJoinRunnerTimeoutTest}} in flink-table-runtime
> * {{AvroOutputFormatITCase}} in flink-avro
> * {{RescalingBenchmarkTest}} and {{StateBackendBenchmarkUtilsTest}} in 
> flink-test-utils



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to