snuyanzin commented on code in PR #28995:
URL: https://github.com/apache/flink/pull/28995#discussion_r4303921524
##########
flink-kubernetes/pom.xml:
##########
@@ -31,7 +31,12 @@ under the License.
<packaging>jar</packaging>
<properties>
- <kubernetes.client.version>7.3.1</kubernetes.client.version>
+ <kubernetes.client.version>7.8.0</kubernetes.client.version>
+ <!-- Fabric8 HTTP client adapter (FLIP-607). Only "jdk" is
shaded, tested and tracked in the NOTICE file.
+ Other adapters (okhttp, jetty, vertx, vertx-5; see
+
https://github.com/fabric8io/kubernetes-client/blob/main/doc/FAQ.md#what-artifacts-should-my-project-depend-on)
+ need their own shading and NOTICE handling. -->
+ <fabric8.httpclient.impl>jdk</fabric8.httpclient.impl>
Review Comment:
by the way now we can use this as `-Dfabric8.httpclient.impl=okhttp`
after building with such flag it will break with `NoClassDefFoundError`
why don't we put it in banned dependencies instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
