SEPURI-SAI-KRISHNA commented on PR #29510: URL: https://github.com/apache/flink/pull/29510#issuecomment-6250692765
@dawidwys @fsk119 could you have a look when you get a chance? Dawid, you added the option in FLINK-37768 and created sink v2 in FLINK-38765. Shengkai, 228de51fb23 is the closest precedent for adding a consumed option. Three things I am not sure about: 1. I added the key to v2 rather than adding a v3. 228de51fb23 did the same, and FLINK-32657 reverted version bumps for a plan metadata change, so a bump seemed wrong here. Can redo it as v3 if you prefer. 2. I left v1 alone. It predates the option, and newContext always resolves the latest annotation. None of the changed goldens has a stream-exec-sink_1 node. 3. release-2.3 has the same gap, should I open a backport? Old plans are unaffected because they fall back to the session value, but newly compiled plans change shape and I was not sure that is fine in a patch release. 2.1 and 2.2 are affected too, but they only have v1 so they would need a different fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
