yunfengzhou-hub commented on code in PR #1271:
URL: https://github.com/apache/flink-agents/pull/1271#discussion_r4309969506
##########
docs/content/docs/get-started/setup.md:
##########
@@ -257,28 +319,29 @@ cp
dist/flink-${FLINK_VERSION%.*}/target/flink-agents-dist-flink-${FLINK_VERSION
{{< /tabs >}}
-### Build Environment Variables
+{{< hint info >}}
+**Note:** The quick install performs this step for you, so you can skip it if
you ran
+`install.sh`.
+{{< /hint >}}
-The following environment variables can be used to control how JARs are
resolved during `pip install flink-agents` (from sdist) or `python -m build`:
+## Developing with the Java API
-| Variable | Description |
-|----------|-------------|
-| `FLINK_AGENTS_SKIP_JAR_DOWNLOAD` | Set to `1`, `true`, `yes`, or `on`
(case-insensitive) to skip downloading JARs from Maven Central. Useful when
building from source with `tools/build.sh`, which copies JARs from the local
Maven build. |
-| `FLINK_AGENTS_MAVEN_MIRROR` | Override the Maven repository base URL for JAR
downloads. Defaults to `https://repo1.maven.org/maven2`. Useful for
environments with restricted network access or internal mirrors. |
+A Java Flink job declares its Agent in Java, so it also needs the Flink Agents
artifacts
+on its compile classpath.
Review Comment:
Fixed in bbb37f13 with your wording. A Java Flink job can load a
YAML-declared Agent, so the lead no longer ties the artifacts to the Agent
definition language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
