MartijnVisser commented on code in PR #28602:
URL: https://github.com/apache/flink/pull/28602#discussion_r4314594246
##########
flink-runtime-web/web-dashboard/src/app/components/job-chart/job-chart.component.ts:
##########
@@ -104,36 +125,40 @@ export class JobChartComponent implements AfterViewInit,
OnDestroy {
ngAfterViewInit(): void {
this.cdr.detach();
- this.chartInstance = new G2.Chart({
+ this.chartInstance = new Chart({
container: this.chart.nativeElement,
- height: 150,
- autoFit: true,
- padding: 'auto'
- });
- this.chartInstance.legend(false);
- this.chartInstance.data(this.data);
- this.chartInstance.scale({
- time: {
- alias: 'Time',
- type: 'time',
- mask: 'HH:mm:ss',
- tickCount: 3
- },
- type: {
- type: 'cat'
- }
+ height: 180,
Review Comment:
At 180 the cards no longer fit the metrics drawer, the Chart/Numeric toggle
ends up under the resize handle. Can we keep this at 150?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
