sangkyoonnam commented on PR #29312:
URL: https://github.com/apache/flink/pull/29312#issuecomment-6270546121
The new commit looks good to me. With auto-generated UIDs disabled,
`set_uid_hash()` on the returned stream now gets through
`get_execution_plan()`, and the `uid()` case still does. I re-ran these checks
with local scripts on PyFlink 2.2.1 and the `data_stream.py` changes from
371beacf. With auto-generated UIDs enabled and `.uid("watermarks")` on the
returned stream, the generated operator IDs in my test topology match what I
got on 9b3a1fcd.
Thanks for adding `set_uid_hash` and for offering to help with `key_by`. The
`key_by` ticket is
[FLINK-41016](https://issues.apache.org/jira/browse/FLINK-41016). I'm planning
to send a PR for it, and I'd appreciate your review when it's up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
