weiqingy commented on PR #1265:
URL: https://github.com/apache/flink-agents/pull/1265#issuecomment-6260619444
Thanks for the reviews. I merged the latest `main` into the branch instead
of rebasing, so the commits already reviewed keep their hashes and nothing was
force-pushed. The squash merge flattens it either way.
- **Conflicts with #1260:** resolved as sangkyoonnam described.
`PojoJsonSchemaGenerator` keeps both sets of imports, and #1260's `Order`,
`PartlyMapped` and `Sign` fixtures sit after `Catalog` in
`PojoJsonSchemaGeneratorTest`. No other file conflicted; #1204's Anthropic
changes merged cleanly.
- **CI:** every Java failure at the old head was the `ExecutionTraceContext`
compile error in `BuiltInInputRunMetricsTest`, which the merge picks up from
#1267. On the merged tree, the common, OpenAI, Anthropic and Gemini chat-model
tests pass (17, 152, 110 and 71) with Spotless, and the Python suite passes
(2342 passed, 15 skipped).
- **Enum fix and `Map` detection together:** they work together. #1260's
enum definition is registered before `reachesAny`'s check and claims only enum
types, so the check still reaches every field beside an enum.
`reachesMapBesideEnumDefinition` (5e2ef147) pins this: `Order`, with only
#1260's enums, is not reported, and `TaggedOrder`, the same enums plus a `Map`,
is.
- **Enum whose `@JsonValue` returns a `Map`:** confirmed, it renders as
`{"type":"string"}` and `reachesAny` doesn't see the `Map`, both before and
after #1260. I'd keep it out of this PR, since it isn't an open-keyed field.
Jackson writes such an enum as an object but can't read that object back
without a `@JsonCreator` (`MismatchedInputException`); it reads back only the
map's `toString()`, such as `"{k=a}"`. So it doesn't round-trip through Jackson
on either path. The enum section #1260 added already notes that a `@JsonValue`
returning another type may need a `@JsonCreator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
