yunfengzhou-hub commented on code in PR #1280:
URL: https://github.com/apache/flink-agents/pull/1280#discussion_r4321094739


##########
docs/content/docs/development/vector-search/vector_stores/_index.md:
##########
@@ -328,7 +328,7 @@ vectorStore.delete(null, "my_collection", null, Map.of());
 {"user_id": "u1", "run_id": "r1"}
 ```
 
-`None` / `null` means "no filter". Richer operators (ranges, set membership, 
OR, NOT, etc.) are out of scope here. Callers needing backend-specific 
operators should pass them through `extra_args` (Python 
`VectorStoreQuery.extra_args` or `**kwargs`) or `extraArgs` (Java) — for 
example, ChromaDB's native `where` dict. Implementations that receive an 
unsupported operator via `filters` raise `NotImplementedError` (Python) or 
`UnsupportedOperationException` (Java).
+`None` / `null` means "no filter". Richer operators (ranges, set membership, 
OR, NOT, etc.) are out of scope here. Callers needing backend-specific 
operators should pass them through `extra_args` (Python 
`VectorStoreQuery.extra_args` or `**kwargs`) or `extraArgs` (Java) — for 
example, ChromaDB's native `where` dict. An unsupported operator is not 
portable. Chroma and Milvus reject it locally with `NotImplementedError` 
(Python) or `UnsupportedOperationException` (Java); the other backends forward 
the value, where the service may reject the query or it may silently match 
nothing. Do not rely on catching a particular exception.

Review Comment:
   Applied. Confirmed both gaps: Milvus checks only `null` and `Map`, Chroma 
only a `$`-prefixed key or a dict value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to