MartijnVisser opened a new pull request, #29559:
URL: https://github.com/apache/flink/pull/29559
## What is the purpose of the change
One exception inside the delayed requirements check or the delayed resource
declaration leaves its debounce future incomplete, so `FineGrainedSlotManager`
never schedules that check again for the rest of the ResourceManager's life.
Details in FLINK-41078.
## Brief change log
- Complete `requirementsCheckFuture` and `declareNeededResourceFuture` in
a `finally`.
## Verifying this change
This change added tests and can be verified as follows:
- Two new tests in `FineGrainedSlotManagerTest`, one per path: the first
delayed check or declaration throws, the second must still run. Both time out
after 5 s on the unmodified tree and pass with the change.
- `FineGrainedSlotManagerTest` 22 of 22 and
`FineGrainedSlotManagerDefaultResourceAllocationStrategyITCase` 18 of 18, none
skipped.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
