wenjin272 commented on code in PR #1307:
URL: https://github.com/apache/flink-agents/pull/1307#discussion_r4343886172
##########
docs/content/docs/development/memory/long_term_memory.md:
##########
@@ -116,7 +121,7 @@ agentsConfig.set(
{{< /tabs >}}
{{< hint info >}}
-If `JOB_IDENTIFIER` is not configured, the Flink job ID will be used by
default.
+If `JOB_IDENTIFIER` is not configured, the current Flink JobID is used as the
job identifier and stored in operator state. If that operator state is
restored, its stored identifier is reused.
Review Comment:
Could we describe the restore behavior without the operator-state detail?
For example: “If `JOB_IDENTIFIER` is not configured, the Flink JobID is used.
Restoring the agent's state from a checkpoint or savepoint retains the previous
identifier, preserving access to the same long-term memories.”
##########
docs/content/docs/development/memory/overview.md:
##########
@@ -80,4 +80,4 @@ For more details, see [Long-Term Memory]({{< ref
"docs/development/memory/long_t
| **Storage** | Flink State | Flink
State | External Vector Store
|
| **Access Pattern** | Key-Value / Nested Objects |
Key-Value / Nested Objects | Semantic Search
|
| **Use Case** | Temporary execution states of an agent run | Exact
information shared across multiple runs | Large, compactable and searchable
information |
-| **Types of Contents** | Any primitive/object | Any
primitive/object | String, ChatMessage
|
\ No newline at end of file
+| **Types of Contents** | Flink-serializable Java values; Python
checkpoint-stable built-ins | Flink-serializable Java values; Python
checkpoint-stable built-ins | String |
Review Comment:
Could we replace “Python checkpoint-stable built-ins” with “Python:
supported built-in values” and link to Supported Value Types? That makes the
supported inputs easier to discover without introducing checkpoint terminology
in the overview.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
