lvyanquan commented on code in PR #4589: URL: https://github.com/apache/flink-cdc/pull/4589#discussion_r4345646744
########## docs/content.zh/docs/connectors/flink-sources/tutorials/build-real-time-data-lake-tutorial.md: ########## @@ -40,29 +40,50 @@ under the License. 你也可以使用不同的 source 比如 Oracle/Postgres 和 sink 比如 Hudi 来构建自己的 ETL 流程。 ## 准备阶段 -准备一台已经安装了 Docker 的 Linux 或者 MacOS 电脑。 +准备一台已经安装了 Docker 的 Linux 或者 macOS 电脑。 -### 准备教程所需要的组件 -接下来的教程将以 `docker-compose` 的方式准备所需要的组件。 +### 准备所需的 JAR 包 +下载以下 JAR 包，并放入与 `Dockerfile` 同级的 `lib` 目录： -使用下面的内容创建一个 `docker-compose.yml` 文件： +- [flink-sql-connector-mysql-cdc-3.7.0-1.20.jar](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-mysql-cdc/3.7.0-1.20/flink-sql-connector-mysql-cdc-3.7.0-1.20.jar) +- [flink-shaded-hadoop-2-uber-2.7.5-10.0.jar](https://repo.maven.apache.org/maven2/org/apache/flink/flink-shaded-hadoop-2-uber/2.7.5-10.0/flink-shaded-hadoop-2-uber-2.7.5-10.0.jar) +- [iceberg-flink-runtime-1.20-1.7.2.jar](https://repo.maven.apache.org/maven2/org/apache/iceberg/iceberg-flink-runtime-1.20/1.7.2/iceberg-flink-runtime-1.20-1.7.2.jar) + +### 启动所需组件 {#准备教程所需要的组件} +本教程使用 Docker Compose 管理所需组件。 + +1. 使用以下内容创建 `Dockerfile`： + +```dockerfile +FROM flink:1.20.5-scala_2.12 +# 将下载的 JAR 包放入同级的 lib 目录。 +COPY ./lib /opt/flink/lib +RUN apt-get update && apt-get install tree ``` + +2. 使用以下内容创建 `docker-compose.yml`： + +```yaml version: '2.1' services: sql-client: user: flink:flink - image: yuxialuo/flink-sql-client:1.13.2.v1 + build: . + command: bin/sql-client.sh Review Comment: The new SQL Client configuration does not match the subsequent instructions. Without `stdin_open` or `tty`, `bin/sql-client.sh` exits after detached startup, leaving no running container for `docker-compose exec`. Also, the later command still invokes `./sql-client`, which does not exist in the official Flink image. I reproduced both issues with `flink:1.20.5-scala_2.12`. Could we keep the container running, for example with `tail -f /dev/null`, and update the later command to `docker-compose exec sql-client /opt/flink/bin/sql-client.sh`? ########## docs/content.zh/docs/connectors/flink-sources/tutorials/build-real-time-data-lake-tutorial.md: ########## @@ -40,29 +40,50 @@ under the License. 你也可以使用不同的 source 比如 Oracle/Postgres 和 sink 比如 Hudi 来构建自己的 ETL 流程。 ## 准备阶段 -准备一台已经安装了 Docker 的 Linux 或者 MacOS 电脑。 +准备一台已经安装了 Docker 的 Linux 或者 macOS 电脑。 -### 准备教程所需要的组件 -接下来的教程将以 `docker-compose` 的方式准备所需要的组件。 +### 准备所需的 JAR 包 +下载以下 JAR 包，并放入与 `Dockerfile` 同级的 `lib` 目录： -使用下面的内容创建一个 `docker-compose.yml` 文件： +- [flink-sql-connector-mysql-cdc-3.7.0-1.20.jar](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-mysql-cdc/3.7.0-1.20/flink-sql-connector-mysql-cdc-3.7.0-1.20.jar) +- [flink-shaded-hadoop-2-uber-2.7.5-10.0.jar](https://repo.maven.apache.org/maven2/org/apache/flink/flink-shaded-hadoop-2-uber/2.7.5-10.0/flink-shaded-hadoop-2-uber-2.7.5-10.0.jar) +- [iceberg-flink-runtime-1.20-1.7.2.jar](https://repo.maven.apache.org/maven2/org/apache/iceberg/iceberg-flink-runtime-1.20/1.7.2/iceberg-flink-runtime-1.20-1.7.2.jar) Review Comment: After switching from the prepackaged image to the official Flink image, the listed JARs are no longer sufficient to run this tutorial. The MySQL CDC SQL connector does not bundle the MySQL JDBC driver, and none of the other listed JARs provides it. Could we also include MySQL Connector/J in the download list so that the source can connect to MySQL? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
