MartijnVisser opened a new pull request, #29563:
URL: https://github.com/apache/flink/pull/29563
## What is the purpose of the change
`FineGrainedSlotManager` ran its delayed checks and periodic work on the RPC
service's scheduler, which outlives the ResourceManager, and `suspend()`
stopped only part of it. Everything now runs through the ResourceManager's main
thread executor and stops in `suspend()`. Details in FLINK-41059.
## Brief change log
- The test Context drives the slot manager through a
`ComponentMainThreadExecutor`, optionally on the test thread.
- Schedule delayed checks and periodic work on the main thread executor;
cancel them in `suspend()`.
- Clear the job state in `suspend()`; `clearResourceRequirements()` checks
`started`, the `canBeReleased` reply checks the registration.
- FLINK-34589: log a failed check and keep running.
- FLINK-34588: the comments from #24309 on the ignored reconcile result.
- `checkInit()`, `start()` and `suspend()` assert the main thread.
## Verifying this change
This change added tests and can be verified as follows:
- Eight new tests in `FineGrainedSlotManagerTest`; the five for the guards
and the logging fail without them.
- `FineGrainedSlotManagerTest` 30 of 30,
`FineGrainedSlotManagerDefaultResourceAllocationStrategyITCase` 18 of 18,
`ResourceManagerTest`, `StandaloneResourceManagerTest` and
`ActiveResourceManagerTest` 34 of 34, the `resourcemanager` package under
`verify` 206 of 206, flink-runtime ITCases 403 of 403, none skipped.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
