sheinbergon commented on PR #29547: URL: https://github.com/apache/flink/pull/29547#issuecomment-6351977725
> thank you for the contribution > > why do we need it working in jdk25 if in previous versions it was caught? Ideally we should have own implementation rather than make it working in complete opposite way see appendix https://openjdk.org/jeps/486 Thanks for the review. To make sure I read you right: this PR does not touch System.exit interception. On JDK <= 23 cluster.intercept-user-system-exit behaves exactly as before. It only fixes FlinkSecurityManager#forceProcessExit, Flink's own exit on fatal errors. Since JDK 24 System.setSecurityManager(null) throws, so on JDK 24+ a fatal error currently leaves the JobManager/TaskManager process hanging instead of exiting (that is why ClusterUncaughtExceptionHandlerITCase hangs on JDK 25). Does this hang fix work for you on its own, with an agent-based replacement for interception (JEP 486 appendix) handled as a separate ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
