[
https://issues.apache.org/jira/browse/FLINK-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854313#comment-15854313
]
ASF GitHub Bot commented on FLINK-5662:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/3277
[FLINK-5662] [table] Rework internal type handling of Table API
This PR refactors the internal type handling of the Table API. It...
- converts type to internal Row type immediately in Batch/StreamScan
- uses only Row type within the operators
- converts to target type at the very end in Batch/StreamTableEnvironment
- removes interfaces for `expectedType`
- removes the config parameter `efficient type usage`
- fixes the generic types (now `Any` means "any type" and `Row` means a
"row type")
- fixes IDE warnings and unused imports where I found them
- fixes the "Alias in front of output fails" issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-5662
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3277
----
commit fdca898407a6e70800ff706c37ed58ea4244a9b0
Author: twalthr <[email protected]>
Date: 2017-02-06T16:18:08Z
[FLINK-5662] [table] Rework internal type handling of Table API
----
> Alias in front of output fails
> ------------------------------
>
> Key: FLINK-5662
> URL: https://issues.apache.org/jira/browse/FLINK-5662
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> Neither of the following snippets works:
> {code}
> public static void main(String[] args) throws Exception {
> final ExecutionEnvironment env =
> ExecutionEnvironment.getExecutionEnvironment();
> DataSet<String> text = ...
> BatchTableEnvironment tEnv = TableEnvironment.getTableEnvironment(env);
> // Table t = tEnv.fromDataSet(text, "text").select("text AS line");
> // Table t = tEnv.fromDataSet(text, "text").as("line");
> Table t = tEnv.fromDataSet(text, "text").select("text AS
> line").select("line AS line");
> tEnv.toDataSet(t, MyPojo.class).print();
> }
> public static class MyPojo {
> public String line;
> }
> {code}
> {code}
> Exception in thread "main" org.apache.flink.table.api.TableException: POJO
> does not define field name: text
> at
> org.apache.flink.table.typeutils.TypeConverter$$anonfun$2.apply(TypeConverter.scala:85)
> at
> org.apache.flink.table.typeutils.TypeConverter$$anonfun$2.apply(TypeConverter.scala:81)
> at scala.collection.immutable.List.foreach(List.scala:318)
> at
> org.apache.flink.table.typeutils.TypeConverter$.determineReturnType(TypeConverter.scala:81)
> at
> org.apache.flink.table.plan.nodes.dataset.BatchScan.convertToExpectedType(BatchScan.scala:69)
> at
> org.apache.flink.table.plan.nodes.dataset.DataSetScan.translateToPlan(DataSetScan.scala:61)
> at
> org.apache.flink.table.api.BatchTableEnvironment.translate(BatchTableEnvironment.scala:305)
> at
> org.apache.flink.table.api.BatchTableEnvironment.translate(BatchTableEnvironment.scala:289)
> at
> org.apache.flink.table.api.java.BatchTableEnvironment.toDataSet(BatchTableEnvironment.scala:146)
> at groupId.WordCount.main(WordCount.java:67)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
