twalthr commented on code in PR #29566:
URL: https://github.com/apache/flink/pull/29566#discussion_r4358525282
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StateTypeStrategy.java:
##########
@@ -19,13 +19,25 @@
package org.apache.flink.table.types.inference;
import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.functions.ProcessTableFunction;
+import org.apache.flink.table.types.DataType;
import javax.annotation.Nullable;
import java.time.Duration;
import java.util.Optional;
-/** Strategy for inferring a function call's intermediate result data type
(i.e. state entry). */
+/**
+ * Strategy for inferring a function call's intermediate result data type
(i.e. state entry).
+ *
+ * <p>For {@link ProcessTableFunction}, returning {@link Optional#empty()}
from {@link
Review Comment:
I would say this is a grey zone. The interface itself has not changed. Also
code implementing it won't. Only the internal utility produces one error less.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]